-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add persistent query and paging #70
add persistent query and paging #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current code requires only minor changes, but I think it does not implement a robust persistent navigation yet.
-
It is possible to restore the search when reloading or coming from another page, but it is not possible to move back/forward on the history of the search page, e.g. the pagination information is part of the url, but going back to a previous page via the browser back button does not work.
-
Classically search parameters are encoded in the query-part of an url. I propose to do this here as well, instead of having them as a part of the path. It might also be better to have the primitive types in plain text in the url, e.g.
/search?offset=0&limit=20&query=<encoded query and ordering>
, as this allows manual override for expert users.
I observed the following changes:
The network traffic suggests that one of the two requests requests the current page and the other requests the expected page. Getting rid of the first one should eliminate most of the problems stated above. |
closes #45 by adding the base64 encoded query to the url